Discrepancies noted from Elements of Java and in-class format:
| File | Line(s) | Violation | Comments |
| MyRuler.java | 1 | ICS-SE-Java-2 | Do not use * in import statements |
| MyRuler.java | 112, 113, 114 | EJS-25 | Use lowercase for the first word and capitalize only the first letter of each subsequent word that appears in a variable name. |
| MyRuler.java | 77, 94, 95, * | EJS-8 | Do not use tabs. |
| MyRuler.java | 132 | EJS-66 | Null statement - maybe this block should've just been omitted? |
| MyRuler.java | 149, 164, 184, * | ICS-SE-Eclipse-2 | Right curly brace should be on same line as if statement |
Other notes: I think the code looks pretty presentable aside from the notes above, or at least better than my code. Strategy for knights is acceptable; peasants could use improvement, but strategy is probably OK since it did fine against the bots.
One more note, is only the first castle commanded to produce knights? I'm not sure what the other castles would produce.
Other than this, it looks fine to me.
No comments:
Post a Comment